Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom scrapy.Request subclass instead of a meta key #12

Closed
kmike opened this issue Feb 28, 2015 · 2 comments
Closed

Use a custom scrapy.Request subclass instead of a meta key #12

kmike opened this issue Feb 28, 2015 · 2 comments

Comments

@kmike
Copy link
Member

kmike commented Feb 28, 2015

Maybe it could work like FormRequest?

This won't work for #11, but with a custom request class / request creation function the user won't be required to add middleware, dupefilter, etc. to settings; also, API could be nicer.

@pablohoffman
Copy link
Contributor

I like this idea, I think it would make the "javascript on scrapy" feel like a better supported feature. I'd imagine it'll also help for a more robust scripting API (by validating lua scripts at request creation time, for example).

@kmike kmike mentioned this issue Mar 29, 2016
20 tasks
@kmike
Copy link
Member Author

kmike commented Apr 11, 2016

There is now SplashRequest.

@kmike kmike closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants