Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Carthage/Carthage Loading
base: master
Choose a base ref
...
head repository: scope-demo/Carthage Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 6 contributors

Commits on Feb 28, 2020

  1. Add Scope Github action 

    Add pull to aotumatic rebase of upstream master
    Ignacio Bonafonte committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    c136644 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Check for and create binaries directory. (#2952) 

    Co-authored-by: Jonathan Bachmann <[email protected]>
    @jonnybach @pull
    2 people authored and pull[bot] committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    dbbd3e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Update README guide for Xcode 11 changes (#2938) 

    * Update README guide for Xcode 11 changes

* Add Xcode 10 and lower instructions
    @yhkaplan @pull
    yhkaplan authored and pull[bot] committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    1804f54 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Update Carthage version to match production (#2966) 

    If you’re looking for the canonical v0.34.0, see <25ad8c8ed7>.

Carthage will have a version bump again for the actual next release.

This just elides a potential «Please update to the latest Carthage version» message for invocations of an executable that’s build off master branch and the like.
    @DavidBrunow @pull
    DavidBrunow authored and pull[bot] committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    5788602 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Fix integration test that is failing on newer versions of Xcode (#2967) 

    Newer versions of Xcode don't have an iPhone 6s by default so this should be a good compromise that works on older and newer versions of Xcode.
    @DavidBrunow @pull
    DavidBrunow authored and pull[bot] committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    eeda608 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Prevent directory traversal (in more piecemeal way) allowing «project… 

    …-directory» flag to function. (#2980)

Also, sanitize [nul characters](https://en.wikipedia.org/wiki/Null_character) in `GitURL`s (transposing them to «␀».)

The cases in the modified test are — given a URL is specified and provided is a string without URL scheme — pathological, and as such the result for them from `GitURL.name` are maybe unintuitive, but decidedly safe.

The flag «--project-directory» clashed with the formerly placed (but never shipped in a tagged Carthage release) invocation of `FileManager.currentDirectoryPath`.

To avoid the clash, we settle on a less intuitive, but most importantly safe change — _to be clear_ a *breaking change* for some pathological URL-scheme–less or nul-character–containing Cartfile lines and `GitURL`s.
    @jdhealy @pull
    jdhealy authored and pull[bot] committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    54841c9 View commit details
    Browse the repository at this point in the history
Loading