-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed regression #245
Comments
Yes, this is somewhat expected, and this is related to what I asked you about recently (see private chat from September 27th). Having many components and chains with multiple steps is the likely cause. I will look again into adding a cache. Can you share the file you used for this? |
The workflows for BIFROST are highly-irregular at the moment, so I wouldn't worry about adding a cache just yet. |
Yes. And we should probably first refactor ESSspectroscopy to use GenericNeXusWorkflow before making any decisions here. |
This is in progress on this branch: https://github.com/scipp/essspectroscopy/tree/nexus-workflow Feel free to contribute if you don't want to wait for me to have time to continue the work. |
As part of
essspectroscopy
I noticed a dramatic runtime increase for thebifrost
workflow after upgrading a dependent package, whereuv
also upgradedscippnexus
from 24.8.0 to 24.10.0.I can run part of the workflow under
cProfile
to work out where the extra time is being spent, e.g.,The change occurs with the latest release, and persists at the current reference on
main
.scippnexus
setting
An example output of the profile recorded as above for 24.10.0 is
Given that the changes in 24.10.0 appear aimed at improved transformation chain loading, is this an indication of a problem with the file I'm loading or with
scippnexus
?The text was updated successfully, but these errors were encountered: