Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor problem browsing the docs #40

Open
blnote opened this issue Jan 23, 2024 · 4 comments
Open

minor problem browsing the docs #40

blnote opened this issue Jan 23, 2024 · 4 comments

Comments

@blnote
Copy link

blnote commented Jan 23, 2024

Hey, I really like the project! Just a minor issue with the documentation at https://scicloj.github.io/clay
(don't know if it is the right place here ?)
I find it kind of hard to browse because when pressing the up/down arrow keys it scrolls to the embedded portal-visualization and focuses it - no matter where I am on the page. May be a browser issue (I'm using Brave), but also occurs in Edge.

Further in both browsers and on mobile I find the headers hard to read in dark-mode
clay

I'm happy to help if needed, best regards!

@daslu
Copy link
Member

daslu commented Jan 23, 2024

@blnote many thanks, this is very helpful.

Yes, Portal is indeed capturing key bindings of the whole page at the moment.
Yesterday on a discussion with Portal's creator @djblue, I wondered whether this was actually a usability problem. It helps to know that it is noticable on your side.

Also thanks for noticing the problem with headers in dark-mode, I haven't figured that out yet.

@daslu
Copy link
Member

daslu commented Jan 23, 2024

Good news: The font colour problems seem to be caused by the embedded Portal as well. With no Portal viewers embedded, the colours are ok.

@daslu
Copy link
Member

daslu commented Jan 23, 2024

Link to Slack #portal discussion: https://clojurians.slack.com/archives/C0185BFLLSE/p1705829969607509

@daslu
Copy link
Member

daslu commented Jan 27, 2024

The dark mode problem seems to be solved in version "2-alpha76" (relying on a temporary pre-release build of Portal).
The keyboard problem remains for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants