Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log a warming when warmup ends without detecting steady state #78

Open
alexeyr opened this issue May 14, 2014 · 3 comments
Open

log a warming when warmup ends without detecting steady state #78

alexeyr opened this issue May 14, 2014 · 3 comments

Comments

@alexeyr
Copy link

alexeyr commented May 14, 2014

Currently it isn't easy to notice in the output when warmup fails to reach steady state: it's just a missing info line. I think it would be good to issue a warning in this case.

@axel22
Copy link
Member

axel22 commented May 29, 2014

739dc58

Since a Warmer is run more than once per benchmark (once per JVM instance), issuing a warning directly from the warmer would emit multiple warning lines when a benchmark is run, so I added a log.verbose.
The questions is how would we decide on a warning if some runs had a successful warmup and others not? Or would you suggest emitting multiple warnings per test?

@alexeyr
Copy link
Author

alexeyr commented May 30, 2014

For my own usecase multiple warnings per test would be fine, but I can see it being a problem in other circumstances. Need to think about it some more.

@axel22
Copy link
Member

axel22 commented May 30, 2014

We could do it so that when there's at least one warmup warning, we emit one warning once the test completes.

This would require adding some additional infrastructure to allow the spawned JVM processes to communicate the warmup warning back to the host JVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants