Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19 fails on Scala 2.12.8 due to CollectionConverters #220

Open
UnconventionalMindset opened this issue Aug 20, 2019 · 4 comments
Open

Comments

@UnconventionalMindset
Copy link

UnconventionalMindset commented Aug 20, 2019

When using Scala 2.12.8 Scalameter 0.19 fails with the sample test throwing:

Exception in thread "main" java.lang.NoClassDefFoundError: scala/jdk/CollectionConverter
...
Caused by: java.lang.ClassNotFoundException: scala.jdk.CollectionConverters
...

Could it be related to CollectionConverters being removed on 2.13 standard Scala but present in 2.12?

@UnconventionalMindset UnconventionalMindset changed the title 0.19 fails on Scala 2.12.7 due to CollectionConverters 0.19 fails on Scala 2.12.8 due to CollectionConverters Aug 20, 2019
@fyodorovski
Copy link
Collaborator

cc @julienrf Do you have any ideas if this could be related in some way to the recent refactoring?

@julienrf
Copy link
Contributor

The scala-collection-compat project does provide scala.jdk.CollectionConverters. This module should have been transitively added to your dependencies.

@UnconventionalMindset
Copy link
Author

I fixed the issue only by adding:

<dependency>
  <groupId>org.scala-lang.modules</groupId>
  <artifactId>scala-collection-compat_2.12</artifactId>
  <version>2.1.2</version>
</dependency>

how can we prevent this in the lib?

@axel22
Copy link
Member

axel22 commented Sep 6, 2019

Maybe we should update the version to 2.1.2 in the ScalaMeter build file, here:

    case Some((2, 12)) => List(
      "org.scala-lang.modules" %% "scala-collection-compat" % "2.1.1",

https://github.com/scalameter/scalameter/blob/master/project/Build.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants