Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add minVideoLength to TrimViewer parameters #188

Open
dkbnz opened this issue Dec 9, 2022 · 3 comments
Open

[Feature Request] Add minVideoLength to TrimViewer parameters #188

dkbnz opened this issue Dec 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dkbnz
Copy link

dkbnz commented Dec 9, 2022

Feature Request:

Add minVideoLength that behaves in the same way maxVideoLength does. Except it prevents the user from trimming a video shorter that minVideoLength.

This would also give the ability to create a "fixed width trim" as requested in this issue by setting max and min equal to each other.

@dkbnz
Copy link
Author

dkbnz commented Dec 9, 2022

I'm happy to put effort into this but cannot find a contributing guide.

@sbis04 sbis04 added the enhancement New feature or request label Jan 8, 2023
@sbis04
Copy link
Owner

sbis04 commented Jan 8, 2023

This is a nice idea! @dkbnz if you want to work on it, I can assign this issue to you.

Yeah, I haven't added a contributing guide to this repo yet. But you can:

  1. Fork this repo
  2. Clone it locally
  3. Create a new branch
  4. Add your changes there
  5. Then submit a PR

@dalijardak
Copy link

Hello guys, any update about this enhancement ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants