-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new density estimator interface into SBI #957
Comments
@gmoss13 I will start with 1) |
Thanks for setting up the issue! I will begin with 2) |
Actually, looking into it a bit: I think
The easiest would be to make "DensityEstimator" or any general "Estimator" a subclass of nn.Module. |
I like the idea with |
Thinking about this some more, not sure how necessary this is? Currently only ratio estimators (I am aware of) are through classifiers, for which we just use
This would only be necessary if we do 3. |
Closing this in favour of #992 as everything else is addressed already. |
Description
Following #952 we need to integrate the new Density Estimator class into SBI
Checklist
Following steps:
posterior_nn
helper function to return the new Density Estimator classlikelihood_nn
helper function to return the new Density Estimator classclassifier_nn
helper function to return ( new Ratio Estimator Class ?)These steps can be worked on almost in parallel.
The text was updated successfully, but these errors were encountered: