Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename classifier to discriminator #1079

Closed
bkmi opened this issue Mar 21, 2024 · 1 comment
Closed

rename classifier to discriminator #1079

bkmi opened this issue Mar 21, 2024 · 1 comment
Assignees
@bkmi
Labels
API changes This impacts the public API of the project (e.g. inference class). enhancement New feature or request hackathon

Comments

@bkmi
Copy link
Contributor

bkmi commented Mar 21, 2024

Is your feature request related to a problem? Please describe.
The functions that call classifier_nn or uses the term classifier, generally are not classifiers.

Describe the solution you'd like
We should rename them to another name like discriminator

Describe alternatives you've considered
Other names like regressor, etc. might be an option.

Additional context
@bkmi bkmi added enhancement New feature or request API changes This impacts the public API of the project (e.g. inference class). hackathon labels Mar 21, 2024
@bkmi bkmi self-assigned this Mar 21, 2024
@bkmi bkmi mentioned this issue Mar 22, 2024
Closed
8 tasks
@janfb
Copy link
Contributor

janfb commented Aug 6, 2024

In the end, we opted for keeping the name classifier to avoid breaking API changes.

@janfb janfb closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkmi bkmi

Labels
API changes This impacts the public API of the project (e.g. inference class). enhancement New feature or request hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janfb @bkmi