-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darken giving different color in 3.2.10 #883
Comments
Can you please provide examples for what changed? |
So if you see the diff here: chinchang/hint.css@aa6681d#L2L174 You'll notice that the colors have changed slightly. Those styles are generated from the line: https://github.com/chinchang/hint.css/blob/master/src/hint-color-types.scss#L19 All I did was update my sass from 3.2.5 to 3.2.10. |
There is no change to the darken function between those releases. Based on your files, I constructed this sass file: .darken {
color: darken(hsl(38, 46%, 54%), 25%);
} In both versions, this file produces: .darken {
color: #6c5328; } I'm closing this, because I think it's not a bug. If you can provide a sass file that produces different results with only the sass version changing, I will reopen. |
I recently updated from 3.2.5 to 3.2.10 and all the color values in CSS which were generated through darken function have now changed slightly. I see nothing related to change in color algorithms in the changelog.
Whats causing the change?
The text was updated successfully, but these errors were encountered: