Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darken giving different color in 3.2.10 #883

Closed
chinchang opened this issue Aug 4, 2013 · 3 comments
Closed

darken giving different color in 3.2.10 #883

chinchang opened this issue Aug 4, 2013 · 3 comments
Labels
bug Something isn't working

Comments

@chinchang
Copy link

I recently updated from 3.2.5 to 3.2.10 and all the color values in CSS which were generated through darken function have now changed slightly. I see nothing related to change in color algorithms in the changelog.

Whats causing the change?

@chriseppstein
Copy link

Can you please provide examples for what changed?

@chinchang
Copy link
Author

So if you see the diff here: chinchang/hint.css@aa6681d#L2L174

You'll notice that the colors have changed slightly. Those styles are generated from the line: https://github.com/chinchang/hint.css/blob/master/src/hint-color-types.scss#L19

All I did was update my sass from 3.2.5 to 3.2.10.

@chriseppstein
Copy link

There is no change to the darken function between those releases.

Based on your files, I constructed this sass file:

.darken {
  color: darken(hsl(38, 46%, 54%), 25%);
}

In both versions, this file produces:

.darken {
  color: #6c5328; }

I'm closing this, because I think it's not a bug. If you can provide a sass file that produces different results with only the sass version changing, I will reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants