Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only error for directly configured core modules #839

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Only error for directly configured core modules #839

merged 1 commit into from
Oct 10, 2019

Conversation

jathak
Copy link
Member

@jathak jathak commented Oct 4, 2019

@jathak jathak requested a review from nex3 October 4, 2019 21:43
@nex3
Copy link
Contributor

nex3 commented Oct 10, 2019

Can you add a changelog entry as well, and bump the pubspec version to 1.23.1-dev?

@jathak jathak merged commit c663995 into master Oct 10, 2019
@jathak jathak deleted the configuration-builtin branch October 10, 2019 21:33
@jathak
Copy link
Member Author

jathak commented Oct 10, 2019

I just realized that I didn't actually git add the changelog entry and version bump when I amended this commit. Should I open a new PR for that or just commit it directly to master?

@nex3
Copy link
Contributor

nex3 commented Oct 10, 2019

Looks like you figured it out in #113?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@use and with(). Error: Built-in modules can't be configured
2 participants
@jathak @nex3