Add documentation comment collection to AST #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
Dec 17, 2018
- Now only removing a single leading space after the '///' when it exists each line.
nex3
approved these changes
Dec 19, 2018
Fixes issue where lines after the first had leading whitespace when the comment started on an indented line.
Also add support for indented syntax to use '///' as the comment prefix applied to following indented lines.
Similar tests in both SCSS and indented syntax.
|
@nex3 PTAL at the tests I added and the changes made to parsing the silent comments in the indented syntax. |
nex3
requested changes
Dec 20, 2018
Fix loop labels to break from the outer loop earlier when indentation level decreases.
nex3
approved these changes
Dec 20, 2018
| } | ||
| outer: | ||
| do { | ||
| var commentPrefix = scanner.scanChar($slash) ? "///" : "//"; |
nshahan
added a commit
to nshahan/dart-sass
that referenced
this pull request
Jan 3, 2019
Originally added in sass#548 but after changes during review it is no longer needed.
Merged
nshahan
added a commit
that referenced
this pull request
Jan 3, 2019
Originally added in #548 but after changes during review it is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation comment collection to Variables, Functions and Mixins.