Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a new missing_return error in Dart 2.1.0-dev.0.0 #445

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

srawlins
Copy link
Contributor

Dart 2.1.0-dev.0.0 raises new missing_return hints on closures assigned as arguments where the parameter return type has been specified. This cleans up those hints for dart-sass.

@srawlins srawlins requested a review from nex3 August 13, 2018 21:54
@nex3
Copy link
Contributor

nex3 commented Aug 13, 2018

Make sure you run pub run grinder after you modify async_evaluate.dart!

@srawlins
Copy link
Contributor Author

Er... done!

@nex3 nex3 merged commit 54192ee into sass:master Aug 14, 2018
@nex3
Copy link
Contributor

nex3 commented Aug 14, 2018

Thanks Sam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants