Stop emitting mixed-decls in a bunch of unnecessary cases
#2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
reviewed
Sep 13, 2024
| : valueSpanForMap = valueSpanForMap ?? value.span { | ||
| {required this.parsedAsCustomProperty, | ||
| Iterable<CssStyleRule>? interleavedRules, | ||
| this.trace, |
There was a problem hiding this comment.
The docs say this isn't set when interleavedRules is empty, but I could make an object that's the opposite of that. Should this have a validation that ensures trace will be null when interleavedRules is null or empty? Or should the documentation on the AST node say that the behavior of trace is undefined when interleavedRules is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#2014