Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bump / arena allocator #16

Open
xldenis opened this issue May 29, 2022 · 2 comments
Open

Use bump / arena allocator #16

xldenis opened this issue May 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@xldenis
Copy link
Collaborator

xldenis commented May 29, 2022

I wonder how much time could be gained by having all formula data stored using arenas. We should investigate using bumpalo for this.

@sarsko
Copy link
Owner

sarsko commented May 30, 2022

Agreed. I see the gain from something like bumpalo much more than I do for smallvec. Still not a fan of additional dependencies, but I think it is worth experimentation at least.

@xldenis
Copy link
Collaborator Author

xldenis commented May 30, 2022

Still not a fan of additional dependencies, but I think it is worth experimentation at least.

While I appreciate the care, and I think it's a good idea, I don't think you should rule out all dependencies. Especially since I think JH and I might do a proof of a bumpalo arena in RHB sometime soon-ish, it's a fun type with a rather elegant model.

@sarsko sarsko added the enhancement New feature or request label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants