Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sangrand as current day if Sanskranti is after 12AM and before Sunrise. #38

Closed
sarabveer opened this issue Jan 7, 2019 · 3 comments · Fixed by #136
Closed

Fix Sangrand as current day if Sanskranti is after 12AM and before Sunrise. #38

sarabveer opened this issue Jan 7, 2019 · 3 comments · Fixed by #136
Assignees
@sarabveer
Labels
bug

Comments

@sarabveer
Copy link
Owner

sarabveer commented Jan 7, 2019 •
edited
Loading

If Sanskranti is after 12AM and before Sunrise, Bikrami Sangrand should be on previous day.

Currently if sanskranti is after 12AM, Sangrand is current day, which doesn't follow the day rule being from Sunrise to Sunrise.

Many Sangrands do not match Punjab sangrands given in Jantri 500
@sarabveer sarabveer self-assigned this Jan 7, 2019
@sarabveer sarabveer added the bug label Jan 7, 2019
@sarabveer
Copy link
Owner Author

@sarabveer
Copy link
Owner Author

@sarabveer
Copy link
Owner Author

https://github.com/kollavarsham/kollavarsham-js/blob/dc6a57afaf08274435768126fb7515e87e3b651d/lib/calendar.js#L293-L331

@sarabveer sarabveer mentioned this issue Jun 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarabveer sarabveer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove kollavarsham and use Calendrica 4.0 for Bikrami Calculations sarabveer/nanakshahi-js
1 participant
@sarabveer