Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Implement a mechanism for synthetic events #43

Open
webknjaz opened this issue Sep 23, 2020 · 1 comment
Open

[TODO] Implement a mechanism for synthetic events #43

webknjaz opened this issue Sep 23, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@webknjaz
Copy link
Member

webknjaz commented Sep 23, 2020

There's some commonly needed events that are combos of a few conditions. One example is PR "merged", GitHub does not emit such an event, it does not exist. But we could make it easier for the end-users to subscribe to it.

The idea is to synthetize fake events that would essentially implement pre-processing of any incoming events and so that the user-defined event handlers are only invoked under certain conditions. Checking the merged PR means checking two flags: closed and merged (because some closed PRs are unmerged).

Users can have a boilerplate for such event but it'd be cleaner to subscribe to a synthetic pull_request.merged event.

I think implementing this feature may also help us implement #36 using the same technique as it would be a synthetic event matching anything too.

Fund with Polar
@webknjaz webknjaz added the enhancement New feature or request label Sep 23, 2020
@webknjaz
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant