Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precommit ci #279

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Precommit ci #279

merged 10 commits into from
Oct 2, 2023

Conversation

ntjohnson1
Copy link
Collaborator

@ntjohnson1 ntjohnson1 commented Sep 30, 2023 •
edited

Resolves #208:

  • Adds nbstripout to dev dependencies
  • Adds pre-commit hook
  • Add github action to run our pre-commit hooks as a test (local test isn't currently possible/easy)
    • See 1a50093 where I intentionally added an executed notebook to confirm test fails

📚 Documentation preview 📚: https://pyttb--279.org.readthedocs.build/en/279/

ntjohnson1 and others added 10 commits September 30, 2023 09:14
@ntjohnson1
CONFIG: Add nbstripout to [dev] and add pre-commit hook
0885bbe
@ntjohnson1
CONFIG: Test just adding test for pre-commit but not fixing failures
8bd915f
@ntjohnson1
CONFIG: Test adding notebook with outputs
1a50093
@ntjohnson1
Revert "CONFIG: Test adding notebook with outputs"
97681a8 
This reverts commit 1a50093
@ntjohnson1
CONFIG: Add args to nbstripout
74d34e0
@dmdunla @ntjohnson1
153 how should this be cited (sandialabs#268)
93a151a 
* Add citation file.

* FIxing names.

* Change to bibtex citation

* Revert "FIxing names."

This reverts commit 429c2c1.

* Remove .bib

* Changing type to misc

* Name fix

* Changing to .bib
@jeremy-myers @ntjohnson1
Change names of tutorials that are for algorithms to start with algor… (
51d0a64 
sandialabs#273)

* Change names of tutorials that are for algorithms to start with algorithm_

* Not an algorithm, so doesn't need algorithm_ prefix.

* Move partial reconstruction of ttensor from standalone tutorial and incorporate into class_ttensor tutorial.

---------

Co-authored-by: Jeremy Myers <[email protected]>
@ntjohnson1
CONFIG: Fix args and non-compliant notebook
00d1fc9
@ntjohnson1
Merge branch 'main' into precommit_ci
84626d1
@ntjohnson1
CONTRIBUTING_DOCS: Add pointer to pre-commit for instructions on runn…
4c9d264 
…ing nbstripout
@ntjohnson1 ntjohnson1 marked this pull request as ready for review September 30, 2023 14:12
@dmdunla dmdunla merged commit 2d3c4c9 into sandialabs:main Oct 2, 2023
8 checks passed
@dmdunla dmdunla mentioned this pull request Oct 2, 2023
Merged
@ntjohnson1 ntjohnson1 deleted the precommit_ci branch October 7, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmdunla dmdunla dmdunla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nbstripout to dev dependencies and commit checks
3 participants
@ntjohnson1 @dmdunla @jeremy-myers