Sptensor mask #259
Merged
Sptensor mask #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it more obvious member rows might not match
jeremy-myers
pushed a commit
to jeremy-myers/pyttb
that referenced
this pull request
Sep 26, 2023
* SPTENSOR: Fix Mask, using tt_ismember_rows incorrectly * PYTTB_UTILS: Design away error: * Make it more obvious member rows might not match
dmdunla
added a commit
that referenced
this pull request
Sep 27, 2023
* Draft tutorial * Created ttensor/reconstruct tutorial in master. * Moved to proper location. * Suppress output * Formatting. * Draft of GCP_OPT tutorial. Requires resolving issue #252. * Potential fix for ValueError in optimizers. * autoformat * Removed from main until completed in branch 248-tutorial-partial-reconstruction-of-a-tucker-tensor. * Restored from upstream main. * Auto formatting. * Commenting out cells that use matplotlib. * Draft tutorial * Moved to proper location. * Suppress output * Formatting. * Draft of GCP_OPT tutorial. Requires resolving issue #252. * Auto formatting. * Commenting out cells that use matplotlib. * Sptensor mask (#259) * SPTENSOR: Fix Mask, using tt_ismember_rows incorrectly * PYTTB_UTILS: Design away error: * Make it more obvious member rows might not match * LaTeX * Decrease the number of maximum iterations for notebook examples to try and avoid time out issues. * Closes #230 --------- Co-authored-by: Jeremy Myers <[email protected]> Co-authored-by: Danny Dunlavy <[email protected]> Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
tt_ismember_rowsincorrectly in mask.-1was a flag for failed match but also yields a valid index into an array. First fixed the bug then updated the ismember_rows interface to try to make this incorrect usage more obvious in the future.Resolves #258
📚 Documentation preview 📚: https://pyttb--259.org.readthedocs.build/en/259/