New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dunder method typing #288

Open

ntjohnson1 opened this issue Nov 3, 2023 · 0 comments

Labels

Collaborator

ntjohnson1 commented Nov 3, 2023

Right now we have no typing on our dunder methods. I think we can be a little more specific both for testing coverage and self documentation.

Example:

@overload
def __eq__(self, other: ttb.tensor) -> bool:
   ...

@overload
def __eq__(self, other: Any) -> Union[NotImplemented, bool]:
   ...

ntjohnson1 added the dev label

ntjohnson1 mentioned this issue

21 sptensor complete documentation for all methods #219

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment