-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install*
fails on Mac OSX
#223
Comments
Can you add a (redacted) example of the fail?
From: Jeremy Myers ***@***.***>
Date: Tuesday, September 5, 2023 at 3:04 PM
To: sandialabs/pyttb ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [EXTERNAL] [sandialabs/pyttb] `make install*` fails on Mac OSX (Issue #223)
Starting with macOS 12.3, Apple no longer ships python<https://developer.apple.com/documentation/macos-release-notes/macos-12_3-release-notes> and instead only ships python3. The calls tomake install, make install_dev, make install_docs fail. It may not be obvious to Mac users how to get around this, since aliasing python to python3 is not a solution.
—
Reply to this email directly, view it on GitHub<#223>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHIY2IV7N3BYTHLWEN6GPFLXY6HU7ANCNFSM6AAAAAA4MLDJCI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Example
Aliasing fails
Updating command line developer tools does not solve the issue. |
It looks like you have aliased python to your python3 install. This will only work for you in your shell in which you aliased this.
You may want to create a symlink from /usr/local/bin/python to /usr/bin/python3 (I do not think you can change /usr/bin without disabling SSV). The symlink should work from any shell (including ones invoked via make).
Although this may fix your issue, this should be documented if aliases do not work with make.
From: Jeremy Myers ***@***.***>
Date: Tuesday, September 5, 2023 at 3:12 PM
To: sandialabs/pyttb ***@***.***>
Cc: Dunlavy, Danny ***@***.***>, Comment ***@***.***>
Subject: [EXTERNAL] Re: [sandialabs/pyttb] `make install*` fails on Mac OSX (Issue #223)
Example
❯ make install
python -m pip install -e .
xcode-select: Failed to locate 'python', requesting installation of command line developer tools.
make: *** [install] Error 72```
# Aliasing fails
❯ which python
python: aliased to /usr/bin/python3
❯ make install
python -m pip install -e .
xcode-select: Failed to locate 'python', requesting installation of command line developer tools.
make: *** [install] Error 72
Updating command line developer tools does not solve the issue.
—
Reply to this email directly, view it on GitHub<#223 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHIY2IUXIYNQJMCVGLENCVLXY6IRLANCNFSM6AAAAAA4MLDJCI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
That is a workaround. However, /usr/local/bin/python exists and my guess is that Apple probably set it alias to /usr/bin/python3. One can change it, but it may need to be reset whenever macOS is updated. This should be called out in the documentation. I'm working on additions to the README that include this. |
If /usr/local/bin/python exists and xcode/make cannot find that, that seems like a problem, too. Or does that point to python2?
From: Jeremy Myers ***@***.***>
Date: Tuesday, September 5, 2023 at 4:09 PM
To: sandialabs/pyttb ***@***.***>
Cc: Dunlavy, Danny ***@***.***>, Comment ***@***.***>
Subject: [EXTERNAL] Re: [sandialabs/pyttb] `make install*` fails on Mac OSX (Issue #223)
That is a workaround. However, /usr/local/bin/python exists and my guess is that Apple probably set it alias to /usr/bin/python3. One can change it, but it may need to be reset whenever macOS is updated. This should be called out in the documentation. I'm working on additions to the README that include this.
—
Reply to this email directly, view it on GitHub<#223 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHIY2IRIRPCE2EMH7MGRQ7LXY6PI7ANCNFSM6AAAAAA4MLDJCI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
The former. /usr/local/bin/python points to /usr/bin/python3 by default. Python2 is not shipped with macOS >= 12.3. |
If you unalias your python alias, does it work? I think the alias is the real culprit here, when called from within makefiles.
From: Jeremy Myers ***@***.***>
Date: Tuesday, September 5, 2023 at 4:15 PM
To: sandialabs/pyttb ***@***.***>
Cc: Dunlavy, Danny ***@***.***>, Comment ***@***.***>
Subject: [EXTERNAL] Re: [sandialabs/pyttb] `make install*` fails on Mac OSX (Issue #223)
The former. /usr/local/bin/python points to /usr/bin/python3 by default. Python2 is not shipped with macOS >= 12.3.
—
Reply to this email directly, view it on GitHub<#223 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHIY2ISSCUDVDQ374RHDB4TXY6P63ANCNFSM6AAAAAA4MLDJCI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
So you should only need the make commands as a dev and our contributing documentation suggests setting up some sort of environment isolation prior to running make/pip installing from source. Would clarifying that be sufficient? Another simpler alternative is to just remove the make commands of they make things more complicated |
I am for removing the Makefile, as the contributing docs already state the commands for the different dev installs. |
I think for full coverage we should:
|
* Move badges to the top and add a few more * Update project so we advertise which python versions we support * Scatter the fact we are on pypi a few redundant places
* Documentation recs: #227 * Add note about normalizing then absorbing weights * Add line separation for score * Add pointer from tovec * Note dims and exclude dims are mutually exclusive in docstring (could do typing overload in the future but should do that more globally) * Fixed the ttv note to pass in default array shape, updated code to accept implicit row, explicit row, and column * Broken markdown link #224: * Fixes link and makes relative path for easier local viewing * Adds github action to check for this in the future (considered linkcheckmd on pypi but hasn't released option to skip ssl verification) * Broken markdown link #224: * Fixes link and makes relative path for easier local viewing * Adds github action to check for this in the future (considered linkcheckmd on pypi but hasn't released option to skip ssl verification) * Ktensor test: * Enforce wrarning for odd number of fixsigns * Also reduces clutter in pytest output * Tensor issymmetric: * Fix bug the incorrectly required version if return_details true * Update typing to be clearer on returns * Add test to enforce/verify behavior * Get rid of Makefile to reduce confusion #223: * Move badges to the top and add a few more * Update project so we advertise which python versions we support * Scatter the fact we are on pypi a few redundant places * Tutorial fixes/improvements #228 * Incorporate threshold in score #225: * Make all asserts inline so optimized mode drops entirely * Make flag True if threshold met and false otherwise. * fixup! Tutorial fixes/improvements #228 * Tutorial formatting: * Add jupyter formatting to black dependency * Run black on notebooks
Starting with macOS 12.3, Apple no longer ships python and instead only ships python3. The calls to
make install
,make install_dev
,make install_docs
fail. It may not be obvious to Mac users how to get around this, since aliasing python to python3 is not a solution.The text was updated successfully, but these errors were encountered: