Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncg: remove dead code #2

Open
dmdunla opened this issue Apr 28, 2019 · 0 comments
Open

ncg: remove dead code #2

dmdunla opened this issue Apr 28, 2019 · 0 comments
Labels
dead code This code cannot be reached enhancement New feature or request to do Will work on this in the future

Comments

@dmdunla
Copy link
Collaborator

dmdunla commented Apr 28, 2019

The following code cannot be reached and should be removed:

            switch (params.Results.Update)
...
                otherwise
                    error('Error: options.Update is not valid. Choices are {FR, PR, HS}');

This cannot be reached because there is a check of the inputs which will prevent the otherwise statement from being executed:

params.addParamValue('Update','PR',@(x) ismember(x,{'FR','PR','HS','SD'}));

NOTE: found using code coverage

@dmdunla dmdunla added enhancement New feature or request to do Will work on this in the future dead code This code cannot be reached labels Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dead code This code cannot be reached enhancement New feature or request to do Will work on this in the future
Projects
None yet
Development

No branches or pull requests

1 participant