Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't resolve 'jalaliday' #58

Closed
sergei-lobanov opened this issue Jun 2, 2023 · 6 comments
Closed

[BUG] Can't resolve 'jalaliday' #58

sergei-lobanov opened this issue Jun 2, 2023 · 6 comments

Comments

@sergei-lobanov
Copy link

When the library version was updated from 1.12.1 to 1.13.0 the build is failed with the error

Expected Behavior

success build

Current Behavior

build is failed with the next error
Module not found: Error: Can't resolve 'jalaliday' in '/var/jenkins_home/src/Common/components/react-trip-date/libs'

Your Environment

  • React Version: 18

Additional Comments

I've tried to do clean up installation removing yarn.lock and generate it again, but it doesn't work.
I don't see anything about jalaliday in the changelog, but I've noticed that the dependency was removed in 1.13.0

ScreenShot 02062023--at 14 58 04@2x

@samsam-ahmadi
Copy link
Owner

samsam-ahmadi commented Jun 2, 2023

@sergei-lobanov Thanks for reporting,
Would you please check this demo application?
https://stackblitz-starters-ro6npi.stackblitz.io
It doesn't have any issue with this version.
Please clear the cache and test it again.

edit:

You can access to editor by this link:
https://stackblitz.com/edit/stackblitz-starters-ro6npi?file=src%2FApp.tsx

@sergei-lobanov
Copy link
Author

@samsam-ahmadi I don't see the issue in the demo app, but its still in my app... Let me check again if I remove all modules and lock file and reinstall everything....
But I suppose that it should work without it.

The issue is that its failing during creation of the build.
ScreenShot 05062023--at 17 16 52@2x

@sergei-lobanov
Copy link
Author

@samsam-ahmadi I did a full clean up of node modules and lock file + cleared the cache, but nothing changed, the same issue.
Also if I search in the project folder I see that react-trip-date use a lot jalaliday inside the module.
Any idea how to fix it? And did you remove it completely or just removed the module from dependency?

ScreenShot 05062023--at 18 49 21@2x

@samsam-ahmadi
Copy link
Owner

samsam-ahmadi commented Jun 5, 2023

@sergei-lobanov Please give me more time to investigate, Would you please downgrade until I check it and then I will let you know. Thanks.

The Keyword Jalali it's not important it's for a specific calendar.
And yes I deleted the *jalaliDay * package. But I replaced it with another package. That is do the same thing as the previews package do.

@sergei-lobanov
Copy link
Author

Any updates on this?

@samsam-ahmadi
Copy link
Owner

@sergei-lobanov Please upgrade to v1.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants