Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Range Picker Doesn't Highlights The Dates Between Selected Date Range #4

Closed
naumanzchaudhry opened this issue Jan 31, 2020 · 3 comments

Comments

@naumanzchaudhry
Copy link

Expected Behavior

When user selects a start date from range picker and moves to select the end date. It should highlight the intermediate date nodes.

Current Behavior

Dates between the dates selected are not highlighted.

Possible Solution

Your Environment

React 16.9.0
Next 9,0.4

@naumanzchaudhry
Copy link
Author

naumanzchaudhry commented Jan 31, 2020

@samsam-ahmadi Seems to work here https://killthejs.com/react-trip-date/?path=/story/range-picker--all-props

Update # 1

RangePicker is behaving more like simple date picker.

Update # 2

From dist/index.d.ts. It seems that date-picker is used even for RangePicker. Which can also be confirmed by inspecting page source. CSS classes that are used for DatePicker are also applied to RangePicker while it's own classes are missing.


export { default as DatePicker } from './calendar/date-picker';
export { default as RangePicker } from './calendar/date-picker';
export { default as theme } from './utils/theme';

@samsam-ahmadi
Copy link
Owner

Hi @naumanzchaudhry, sorry for the late answer.
I've been working on a new version of it.
If you want, you can help me with this at Develop branch.

@samsam-ahmadi
Copy link
Owner

Hi @naumanzchaudhry, I fixed it in the new Version. 1.3.0.
Also in this version, we had some new props and the performance got better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants