-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: do.Shutdown returning shutdown time ? #32
Milestone
Comments
Hello, thanks for this proposal. I like this idea, my 2 cents here is : If we already return information about the shutdown, perhaps we can also return several other informations. e.g. the number of services actually closed, the time elapsed, potential errors. type ShutdownFeedback struct {
All time.Duration
Services map[string]time.Duration
ServicesError map[string]error // each errors returned by each services shutdown
servicesTurnedOff int
// maybe something else ?
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My monolith application relies a lot on
do.Shutdownable
interface. Some tasks call database or third-parties, and flush buffer.I would like to measure the time of the
do.Shutdown
processing.API proposal:
duration, err := do.Shutdown()
duration
would be either atime.Duration
or:WDYT ?
The text was updated successfully, but these errors were encountered: