Windows runas command issue

[tsaridas]

Description of Issue/Question

salt -L windows-minion cmd.run '"c:\Program Files\dir\file.exe" -g && echo foo' runas=user password=FooBar

will not be able to find file.exe but when you do

salt -L windows-minion cmd.run '"c:\Program Files\dir\file.exe" -g' runas=user password=FooBar

it works.

Versions Report

Checked the code and it has always been like that so it affects all versions when runas is used.

Fix

https://github.com/saltstack/salt/blob/develop/salt/utils/win_runas.py#L344
can be changed to :

cmd = 'cmd /c ({0})'.format(cmd)

[gtmanfred]

Would you mind submitting a PR for this?

Thanks,
Daniel

[gtmanfred]

https://docs.saltstack.com/en/latest/topics/development/contributing.html

[tsaridas]

maybe @twangboy can have a look ?
I have no problem submitting a pr if he also thinks this is the correct solution.

[twangboy]

@tsaridas That's probably fine. You'll also need to add it here: https://github.com/saltstack/salt/blob/develop/salt/utils/win_runas.py#L418

[damon-atkins]

cmd.shell is meant to invoke the shell to run a command e.g. cmd.exe
cmd.run is meant to run things as is it should not prefix it with a shell.

The above is a bad fix. Please try cmd.shell , these was some code updates which said if Windows the Shell use %COMSPEC%.

[twangboy]

@tsaridas Does cmd.shell fix your issue? If so, I'd like to rescind my above statement.

[tsaridas]

@damon-atkins the only thing that cmd.shell does it enable python shell and calls cmd.run .

In cmd._run when setting runas & password python_shell doesn't do anything since it exists before python_shell changes the command.

https://github.com/saltstack/salt/blob/develop/salt/modules/cmdmod.py#L409

I can confirm tomorrow after some testing but code seems to be the same.

[damon-atkins]

So if cmd.shell does not result in runing cmd /s /c then it needs to be fixed.

[tsaridas]

may I suggest to change to
'cmd /s /c "{0}"'
What do you think ?

[damon-atkins]

That's fine the /s indicates its in " you can look at the current 2016.11 branch for examples in win_pkg, which I fixed a about 2 months ago. Just needs to be coded so its only applied when a shell is wanted (but windows gets cmd instead of a unix shell)

[twangboy]

@cachedout Should cmd.shell prefix the command with cmd /s /c? Should it open whatever command is passed in the shell? Is that what cmd.shell is supposed to do?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale]

Thank you for updating this issue. It is no longer marked as stale.