Improve Windows support to user.present state function

[twangboy]

Feature request to add the ability to set the password to never expire from a state along with other Windows specific option.

Make the parameters for user.update available in user.add.

#38544

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[henrikor]

Did this ever get implemented? I get "ERROR executing 'state.apply': 'password_never_expires' is an invalid keyword argument for 'user.present'" when trying to use it.

If it's only me doing it wrong - I can't find it documented in: https://docs.saltstack.com/en/latest/ref/states/all/salt.states.user.html

If it's not implemented - it would be nice to get it implemented :-)

[bsoldhogg]

Yeah I'm not seeing this as implemented in 3000. If I run a simple user.present:

local_admin:
  user.present:
    - name: myadmin
    - groups:
      - Administrators
      - Users
    - fullname: Admin

It returns:

ID: local_admin
    Function: user.present
        Name: myadmin
      Result: True
     Comment: New user myadmin created
     Started: 10:54:20.554344
    Duration: 348.091 ms
     Changes:
              ----------
              account_disabled:
                  False
              account_locked:
                  False
              active:
                  True
              comment:
              description:
              disallow_change_password:
                  False
              expiration_date:
                  2106-02-07 06:28:15
              expired:
                  True
              failed_logon_attempts:
                  0
              fullname:
                  Admin
              gid:
              groups:
                  - Administrators
                  - Users
              home:
              homedrive:
              last_logon:
                  Never
              logonscript:
              name:
                  myadmin
              passwd:
                  None
              password_changed:
                  2020-05-08 10:54:20
              password_never_expires:
                  False
              profile:
                  None
              successful_logon_attempts:
                  0
              uid:
                  uid

But adding password_never_expires causes the state to fail:

ERROR executing 'state.apply': 'password_never_expires' is an invalid keyword argument for 'user.present'

@twangboy

[hemantaltair]

It's not implemented I am getting same error