From 06c4f313fdb5edcd7624beb55e2267496e9fa916 Mon Sep 17 00:00:00 2001 From: Tuan Nguyen Date: Fri, 9 Aug 2019 13:53:23 -0700 Subject: [PATCH 1/2] add FeatureDistribution to SerializationFormats --- core/src/main/scala/com/salesforce/op/ModelInsights.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/scala/com/salesforce/op/ModelInsights.scala b/core/src/main/scala/com/salesforce/op/ModelInsights.scala index 4df91b8e12..a3741a42c6 100644 --- a/core/src/main/scala/com/salesforce/op/ModelInsights.scala +++ b/core/src/main/scala/com/salesforce/op/ModelInsights.scala @@ -393,7 +393,7 @@ case object ModelInsights { val SerializationFormats: Formats = { val typeHints = FullTypeHints(List( - classOf[Continuous], classOf[Discrete], + classOf[FeatureDistribution], classOf[Continuous], classOf[Discrete], classOf[DataBalancerSummary], classOf[DataCutterSummary], classOf[DataSplitterSummary], classOf[SingleMetric], classOf[MultiMetrics], classOf[BinaryClassificationMetrics], classOf[BinaryClassificationBinMetrics], classOf[ThresholdMetrics], From 161e66efd587d2b18d9f952e6b9457625438457d Mon Sep 17 00:00:00 2001 From: Tuan Nguyen Date: Fri, 9 Aug 2019 13:59:07 -0700 Subject: [PATCH 2/2] adding subclasses --- core/src/main/scala/com/salesforce/op/ModelInsights.scala | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/com/salesforce/op/ModelInsights.scala b/core/src/main/scala/com/salesforce/op/ModelInsights.scala index a3741a42c6..9882475c28 100644 --- a/core/src/main/scala/com/salesforce/op/ModelInsights.scala +++ b/core/src/main/scala/com/salesforce/op/ModelInsights.scala @@ -35,7 +35,7 @@ import com.salesforce.op.features._ import com.salesforce.op.features.types._ import com.salesforce.op.filters._ import com.salesforce.op.stages._ -import com.salesforce.op.stages.impl.feature.TransmogrifierDefaults +import com.salesforce.op.stages.impl.feature.{TextStats, TransmogrifierDefaults} import com.salesforce.op.stages.impl.preparators._ import com.salesforce.op.stages.impl.selector._ import com.salesforce.op.stages.impl.tuning.{DataBalancerSummary, DataCutterSummary, DataSplitterSummary} @@ -46,6 +46,7 @@ import com.salesforce.op.utils.spark.RichMetadata._ import com.salesforce.op.utils.spark.{OpVectorColumnMetadata, OpVectorMetadata} import com.salesforce.op.utils.table.Alignment._ import com.salesforce.op.utils.table.Table +import com.twitter.algebird.Moments import ml.dmlc.xgboost4j.scala.spark.OpXGBoost.RichBooster import ml.dmlc.xgboost4j.scala.spark.{XGBoostClassificationModel, XGBoostRegressionModel} import org.apache.spark.ml.classification._ @@ -393,7 +394,8 @@ case object ModelInsights { val SerializationFormats: Formats = { val typeHints = FullTypeHints(List( - classOf[FeatureDistribution], classOf[Continuous], classOf[Discrete], + classOf[FeatureDistribution], classOf[Moments], classOf[TextStats], + classOf[Continuous], classOf[Discrete], classOf[DataBalancerSummary], classOf[DataCutterSummary], classOf[DataSplitterSummary], classOf[SingleMetric], classOf[MultiMetrics], classOf[BinaryClassificationMetrics], classOf[BinaryClassificationBinMetrics], classOf[ThresholdMetrics],