Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordInsightsLOCO#returnTopPosNeg complexity is =0(n^2 * log n) per vector generation #376

Closed
gerashegalov opened this issue Jul 30, 2019 · 1 comment
Closed

RecordInsightsLOCO#returnTopPosNeg complexity is =0(n^2 * log n) per vector generation #376

gerashegalov opened this issue Jul 30, 2019 · 1 comment

Comments

@gerashegalov
Copy link
Contributor

Describe the bug
returnTopPosNeg creates sparse vectors in a loop over bits. Vectors.sparse sorts the indices array

To Reproduce
Enable LOCO

Expected behavior
Using DenseVector for 0(1) generating of LOCO vectors

Logs or screenshots
Screen Shot 2019-07-30 at 10 29 23 AM
@gerashegalov gerashegalov changed the title RecordInsightsLOCO#returnTopPosNeg complexity is =0(n^2 * log n) per record RecordInsightsLOCO#returnTopPosNeg complexity is =0(n^2 * log n) per vector generation Jul 30, 2019
@gerashegalov gerashegalov mentioned this issue Jul 30, 2019
Merged
@gerashegalov
Copy link
Contributor Author

fixed in #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gerashegalov