Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw Feature Filter should throw exception when removing all features #302

Closed
crupley opened this issue Apr 26, 2019 · 1 comment
Closed

Comments

@crupley
Copy link
Contributor

crupley commented Apr 26, 2019

Problem
Currently, the Raw Feature Filter can remove all features and there is no way to communicate that signal in the pipeline. This is different for how the same situation is handled in the Sanity Checker. See:

require(indicesToKeep.length > 0,
"The sanity checker has dropped all of your features, check your input data quality")

Solution
Require that the raw feature filter return at least one feature after filtering so that behavior is consistent with similar feature filtering stages.

Alternatives
An alternative would be to throw no exception in either case and require all stages to support zero-length vectors.

Additional context
Nah

@crupley
Copy link
Contributor Author

crupley commented May 13, 2019

Feature added

@crupley crupley closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant