Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag Problem #151

Open
oguzhaniptes opened this issue May 9, 2024 · 9 comments
Open

Drag Problem #151

oguzhaniptes opened this issue May 9, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@oguzhaniptes
Copy link

Describe the bug
I encountered the issue of the GNOME desktop crashing when I held down the extension while dragging it anywhere.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Topbar'
  2. Click on Extension'
  3. Drag to 'Enywhere'
  4. See error

Expected behavior
Open media control panel.

Environment:

  • Distro: Arch Linux
  • GNOME version 46
  • Extension Version 2.0.1
@oguzhaniptes oguzhaniptes added the bug Something isn't working label May 9, 2024
@ChrisLauinger77
Copy link
Collaborator

ChrisLauinger77 commented May 9, 2024

I cannot drag the extension anywhere ...
Not sure how you manage that ...
Can you record it and post here ?

@oguzhaniptes oguzhaniptes changed the title Drag Propblem Drag Problem May 9, 2024
@oguzhaniptes
Copy link
Author

oguzhaniptes commented May 9, 2024

I just clicked and dropped it somewhere.
It's very strange, I discovered it by mistake

VID_20240509_161904.online-video-cutter.com.mp4

@ChrisLauinger77
Copy link
Collaborator

The scrolling is enabled. I tried it without scrolling. Nothing happenend ...

@chase1k
Copy link

chase1k commented May 11, 2024

I have the same issue as oguzhaniptes. Any clicking and dragging causes it to crash.

@sakithb
Copy link
Owner

sakithb commented May 19, 2024

The crash logs point to this line,

const device = tapAction.get_device(tapAction.nTouchPoints - 1);

I don't have any idea what is going wrong here, but I will investigate later.

@ChrisLauinger77
Copy link
Collaborator

ChrisLauinger77 commented May 20, 2024

I do not see any crash logs here ?
But seems the device at index "tapAction.nTouchPoints - 1" is not there ?
I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

@sakithb
Copy link
Owner

sakithb commented May 22, 2024

I do not see any crash logs here ? But seems the device at index "tapAction.nTouchPoints - 1" is not there ? I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

I didn't post the logs here, but I was able to reproduce it on fedora.

@ChrisLauinger77
Copy link
Collaborator

I C.
Maybe trace out "tapAction.nTouchPoints" - I have the feeling it returns 0 under some cirumstances and then the -1 is not a good idea ...

@sakithb
Copy link
Owner

sakithb commented Jun 19, 2024

Seems like that isn't the issue. I tried by clamping the no of points to always be 0 or greater. Even after commenting out that code, it still crashes. My guess this is an error in the implementation of tap action itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants