[WIP] Rewriting the internals of how the extension works #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisLauinger77 If you have some time on your hands to test this, I would love to hear your feedback |
I am on vacation. Flying back next Saturday. So earliest Sunday I can have a look. |
Sure |
Fixed bugs in button label relating to the artist The player proxy now polls the player till there is a length after it is initialized
This was
linked to
issues
Jan 5, 2024
Closed
|
@ChrisLauinger77 Hey, I added a small change that might just fix this. Can you try that out? |
|
Btw are you using any unstable version of a program in the GNOME stack? like a beta or testing version |
Not really - and I also tested v31 with my current setup. This one works without major issues. |
|
the changes do not really help :( |
|
And then when I stop spotify after start with no music ever played I get this: It is also unexpected - is this also happening for U ? |
Yes it is supposed to be like that, those messages will only log in debug mode |
Really ? This is showing up in log when I just start spotify. |
Most of those won't be logged in release mode. |
I will look into this in a bit, this might be caused by the last commit. |
|
Btw, how did you compile these files? No matter how I build, the |
"Added menu slider" is logged multiple times - but only 1 slider is added. Confusing. |
It's because the existing sliders are being replaced |
|
When ever metadata, position/length of the media get's updated the slider gets replaced. |
I edited the .js in the deployment folder for testing / debugging. And prettier reformatted |
In v31 the slider is not replaced, right ? Why is it replaced ? Can we just use 1 slider and update it ? |
It is implemented differently here, in v31 the slider queries the current position from the mpris object every one second, and updates the value, which is a really bad method, the new version query the position at the start of the song and animates the slider for the duration of the song, which is a way cleaner and performant approach. |
|
Can you send your edited |
|
I just let Spotify play on its own for 30 minutes and checked the logs, there was nothing unexpected like spam or logs. I think we should release the new version now and if other poeple are also experiencing the same issue, we can work towards a fix. |
I downgraded to v31 and lost my changes. They where not working anyways |
I still see sometimes spotify stopped but the slider animates. |
Fine lets see what EGO review has as result. If the release is not working for me I still can downgrade to v31 which does and have a working version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
Todos
Issues