Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider "scraping" GitLab instances for extracting a developer's or packager's pretty name #81

Open
Olf0 opened this issue Apr 14, 2022 · 4 comments

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Apr 14, 2022

From the discussion for PR #80, point 2c:

For obtaining a name at GitLab, as a fallback the URL might be parsed, though this provides the login name, not the pretty name, see, e.g.: https://gitlab.com/Olf0/sailfishX Although the pretty name can be extracted as the first string on a GitLab user page proper (when ignoring GitLab's top menu bar), see, e.g.: https://gitlab.com/Olf0

Note that I believe to remember that the pretty name can be left empty: IMO it makes sense to use the login name as a fallback, then.

As discussed for points 2a & 2b (not yet concluded), it might make sense to query the ultimately determined source code repository (out of {m_repo_url, m_url}) for the developer's name and the m_packaging_repo_url for the packager's name.

Side note: In general I do not like web-page "scraping", because web-pages are often altered. But in this case, I believe that the pretty name will very likely always be right below the avatar picture, so this is a sustainable solution.

@rinigus
Copy link
Collaborator

rinigus commented Apr 14, 2022

No, I would avoid scraping. We are using GitLab GraphGL API. If there is a call to get "Pretty name" we can use it, if there is none then we better skip pretty name. There is a fallback anyway as it can be specified in Chum section of the SPEC.

@Olf0
Copy link
Collaborator Author

Olf0 commented Apr 15, 2022

We are using GitLab GraphGL API. If there is a call to get "Pretty name" we can use it, […]

I assumed there is none, because retrieving the pretty name via API was not implemented for GitLab, in contrast to GitHub. For sure using a defined API is always better than "web-page scraping".

No, I would avoid scraping.

Well, that was what point 2c of PR #80 was all about, due to my "jumping to conclusions".

@rinigus
Copy link
Collaborator

rinigus commented Apr 15, 2022

In my mind it was about parsing URL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants