Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot import music managed/converted by beets to OGG/Vorbis format #97

Open
RTheren opened this issue May 28, 2024 · 4 comments
Open
Labels
bug Something isn't working

Comments

@RTheren
Copy link

RTheren commented May 28, 2024

SailfishOS VERSION (Settings → About product → Build): 4.5.0.25

HARDWARE (Settings → About product → Manufacturer & Product name): Volla Phone 22

FlowPlayer VERSION (FlowPlayer → [Top pulley] Settings → [Top pulley] About): 0.3.5

BUG DESCRIPTION

I am unable to import my .ogg music that I manage and convert with beets program on PC. Tapping on "Update collection" after selecting the Music folder gives me this in journalctl:

May 28 12:58:25 Volla22 flowplayer[14716]: [D] unknown:0 - PROCESSING FILE: "/home/defaultuser/Music/Alestorm/No Grave but the Sea/01 - No Grave but the Sea.ogg" "INVALID TAG"
May 28 12:58:25 Volla22 lipstick[2903]: TagLib: Vorbis::File::read() - Could not find the Vorbis comment header.
May 28 12:58:25 Volla22 flowplayer[14716]: [D] unknown:0 - PROCESSING FILE: "/home/defaultuser/Music/Alestorm/No Grave but the Sea/05 - Bar ünd Imbiss.ogg" "INVALID TAG"
May 28 12:58:26 Volla22 lipstick[2903]: TagLib: Vorbis::File::read() - Could not find the Vorbis comment header.
May 28 12:58:26 Volla22 flowplayer[14716]: [D] unknown:0 - PROCESSING FILE: "/home/defaultuser/Music/Alestorm/No Grave but the Sea/03 - To the End of the World.ogg" "INVALID TAG"

STEPS TO REPRODUCE

  1. Setup conversion format for beets like so:
    formats:
      opus: 
        command: ffmpeg -i $source -y -vn -acodec libopus -ab 96k $dest
        extension: ogg
  1. Copy music to phone
  2. Try to import

ADDITIONAL INFORMATION

Beets uses MusicBrainz for backend for filling in tags. Sometimes I update the albums manually with MusicBrainz Picard, but that doesn't seem to change the outcome. I can upload some ogg files here for further investigation.
Including output from ffprobe from one of the affected files:
ffprobe.txt

@RTheren RTheren added the bug Something isn't working label May 28, 2024
@Olf0
Copy link
Contributor

Olf0 commented May 29, 2024

@rubdos, any interest to take a look at this, when you can spare some time?

@Olf0 Olf0 changed the title [Bug] Cannot import music managed/converted by beets [Bug] Cannot import music managed/converted by beets to OGG/Vorbis format May 29, 2024
@rubdos
Copy link
Contributor

rubdos commented May 29, 2024

FWIW, I'm using .opus files with Beets. You seem to be using Ogg/Opus though, not Ogg/Vorbis, so probably that needs changing in the issue title.

I would say that Meta::getFileByMimeType and DataReader::getFileByMimeType need a patch to distinguish Ogg Vorbis from Ogg Opus based on the file content.

As a workaround, @RTheren, you can change your beets config to use the .opus file extension.

@RTheren
Copy link
Author

RTheren commented May 29, 2024

Tried it on a single file, and yeah changing to opus does seem to make it appear in the player. The .ogg might have been left from when I had the Vorbis before changing to Opus without changing the extension. So far, only FlowPlayer has complained about this. Thanks for the fix :)

@rubdos
Copy link
Contributor

rubdos commented May 30, 2024

So far, only FlowPlayer has complained about this.

Yeh, because FlowPlayer makes a wrong assumption :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants