-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spkg-configure.m4 for glpk #28459
Comments
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:4
Does anyone know a system that does not carry Sage's GLPK patch? |
comment:5
Debian 10 carries GLPK 4.65, and 4 tests in |
comment:6
Replying to @dimpase:
Same for Arch. Given that 4.65 is 1.5 years old and most distros are shipping it already, IMO it would be best to update sage's glpk first before dealing with this. |
comment:7
I've put the update to glpk 4.65 on #24824 |
Dependencies: #24824 |
comment:8
On #24824 I've also adjusted tests so ithat only one test fails with Debian's glpk 4.65, which does not apply one of Sage's patches, (And in fact the still failing test can be switched off or changed into something that does not need the patch in question). |
comment:9
here I keep minimal requirement version of glpk to be 4.63. This results in few failing tests, all just from glpk 4.63 being too chatty in logging, nothing serious. |
comment:10
Looks good to me in principle though I haven't tested yet. I'll try to test later this week. Thanks! |
comment:11
ping? |
comment:13
Works for me in conda |
comment:14
Reviewer name... |
Reviewer: Isuru Fernando |
Changed branch from u/dimpase/packages/glpkconfig to |
the external install should have
glpsol
andlibglpk
On debian they are in
glpk-utils
andlibglpk-dev
packages.4ti2
needs to know its prefix (or probably just--with-glpk
should be there).Anyhow, we introduce a new env. var.
SAGE_GLPK_PREFIX
which is
''
for system'sglpk
andSAGE_LOCAL
otherwise.cvxopt
for itsglpk
extension needs to know the (non-standard) include directory andlibrary directory of
glpk
, so they can be made blankfor the stanard locations --- but as in particular libPython comes from
SAGE_LOCAL
, this should be left unchanged for the time being.Sage's
glpk
needs a specific patch which is not upstreamed, so we need to work this out, too.Depends on #24824
CC: @embray @kiwifb @isuruf @antonio-rojas @mkoeppe
Component: build: configure
Author: Dima Pasechnik
Branch/Commit:
e6bb511
Reviewer: Isuru Fernando
Issue created by migration from https://trac.sagemath.org/ticket/28459
The text was updated successfully, but these errors were encountered: