Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure.m4 for glpk #28459

Closed
dimpase opened this issue Sep 6, 2019 · 19 comments
Closed

spkg-configure.m4 for glpk #28459

dimpase opened this issue Sep 6, 2019 · 19 comments

Comments

@dimpase
Copy link
Member

dimpase commented Sep 6, 2019

the external install should have glpsol and libglpk

On debian they are in glpk-utils and libglpk-dev packages.

4ti2 needs to know its prefix (or probably just --with-glpk should be there).
Anyhow, we introduce a new env. var. SAGE_GLPK_PREFIX
which is '' for system's glpk and SAGE_LOCAL otherwise.

cvxopt for its glpk extension needs to know the (non-standard) include directory and
library directory of glpk, so they can be made blank
for the stanard locations --- but as in particular libPython comes from SAGE_LOCAL, this should be left unchanged for the time being.


Sage's glpk needs a specific patch which is not upstreamed, so we need to work this out, too.

Depends on #24824

CC: @embray @kiwifb @isuruf @antonio-rojas @mkoeppe

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: e6bb511

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28459

@dimpase dimpase added this to the sage-8.9 milestone Sep 6, 2019
@dimpase

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 7, 2019

Changed commit from 2f10a52 to 08d353c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 7, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

08d353cspkg-configure.m4 for glpk

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 7, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e6bb511spkg-configure.m4 for glpk

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 7, 2019

Changed commit from 08d353c to e6bb511

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Sep 7, 2019

comment:4

Does anyone know a system that does not carry Sage's GLPK patch?
(I guess Debian does, right?)

@dimpase
Copy link
Member Author

dimpase commented Sep 7, 2019

comment:5

Debian 10 carries GLPK 4.65, and 4 tests in src/sage/numerical/backends/glpk_backend.pyx fail due to minor formating differences, e.g. extra blank line...

@antonio-rojas
Copy link
Contributor

comment:6

Replying to @dimpase:

Debian 10 carries GLPK 4.65, and 4 tests in src/sage/numerical/backends/glpk_backend.pyx fail due to minor formating differences, e.g. extra blank line...

Same for Arch. Given that 4.65 is 1.5 years old and most distros are shipping it already, IMO it would be best to update sage's glpk first before dealing with this.

@dimpase
Copy link
Member Author

dimpase commented Sep 9, 2019

comment:7

I've put the update to glpk 4.65 on #24824

@dimpase
Copy link
Member Author

dimpase commented Sep 9, 2019

Dependencies: #24824

@dimpase
Copy link
Member Author

dimpase commented Sep 9, 2019

comment:8

On #24824 I've also adjusted tests so ithat only one test fails with Debian's glpk 4.65, which does not apply one of Sage's patches, glpk/patches/error_recovery.patch.

(And in fact the still failing test can be switched off or changed into something that does not need the patch in question).

@dimpase
Copy link
Member Author

dimpase commented Sep 10, 2019

comment:9

here I keep minimal requirement version of glpk to be 4.63. This results in few failing tests, all just from glpk 4.63 being too chatty in logging, nothing serious.

@embray
Copy link
Contributor

embray commented Sep 11, 2019

comment:10

Looks good to me in principle though I haven't tested yet. I'll try to test later this week. Thanks!

@dimpase
Copy link
Member Author

dimpase commented Oct 6, 2019

comment:11

ping?

@dimpase dimpase modified the milestones: sage-8.9, sage-9.0 Oct 6, 2019
@isuruf
Copy link
Member

isuruf commented Oct 6, 2019

comment:13

Works for me in conda

@vbraun
Copy link
Member

vbraun commented Oct 6, 2019

comment:14

Reviewer name...

@isuruf
Copy link
Member

isuruf commented Oct 6, 2019

Reviewer: Isuru Fernando

@vbraun
Copy link
Member

vbraun commented Oct 7, 2019

Changed branch from u/dimpase/packages/glpkconfig to e6bb511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants