function to get TFL traffic calming data from CID

[PublicHealthDataGeek]

ct has code

[layik]

Hi @PublicHealthDataGeek! Can you elaborate in case I want to get a draft of this. "ct" stands for?

[PublicHealthDataGeek]

@layik actually the work is already done as part of an earlier package Robin I wrote https://github.com/PublicHealthDataGeek/CycleInfraLnd to extract TFL Cycling Infrastructure Database data. This was a placeholder to remind us to include it here.

The snippet from CycleInfraLnd is below with the type in this case being "traffic_calming" (the CID contains other data types too)

get_cid_points = function(type) {
base_url = "https://cycling.data.tfl.gov.uk/CyclingInfrastructure/data/points/"
cid_url = paste0(base_url, type, ".json")
sf::read_sf(cid_url)
}

so would the function be 'get_cid_trafficcalming' or similar depending on what you have named other functions.

ct stands for Caroline Tait!

[PublicHealthDataGeek]

Just noted that there is already a fucntion in safeactive for obtaining OSM traffic calming data:
traffic_calming_points = tc_get_osm(bbox = "chapeltown leeds")

the CID has different strengths and weaknesses compared to OSM. Perhaps this is more of a conceptual/strategic issue for @Robinlovelace to be involved in. would be a shame to not include the CID data which is 'official'.

[Robinlovelace]

Yes we should include CID data and functions to ease getting it is my thinking. One question @PublicHealthDataGeek can we use your functions here? You could put in a PR to contribute them directly...

[layik]

OK, now I know what "CT" stands for, happy to leave it for her.

[PublicHealthDataGeek]

Yes we can use my functions here. Might just need to think about naming of the function so that it differentiates it from the 'traffic_calming_points'. How about 'TFL_CID_traffic_calming_points'?

As mentioned on issue #15 I am happy to draft some code but might just need a hand to incorporate into package etc.