Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a Switch Network button if wallet is connected to a different chain #3743

Open
usame-algan opened this issue May 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@usame-algan
Copy link
Member

What is the feature about

The connected wallet needs to be on the same network as the safe in order for the user to sign/execute transactions. The current implementation to ensure this consists of multiple parts:

  • We display a WrongChainWarning in some transaction modals
  • We call assertWalletChain in some dispatch functions

This approach is not consistent e.g. we don't call assertWalletChain when creating a safe apps transactions and its easy to miss when adding a new feature. Another issue is that we combine switching the chain and executing/signing a transaction. While this "saves" the user a click, it can also be confusing if one click leads to the wallet popping up twice.

The list of requirements

Ideally, we would have this in one place like CheckWallet and don't show a warning at all but instead show a different button than the action button to prompt the user to switch their network.

Designs/sketches

Screenshot 2024-05-24 at 13 03 23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: New issues
Development

No branches or pull requests

1 participant