Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Restrict privileged command to bot admins #14

Closed
Generator opened this issue Feb 20, 2024 · 3 comments · Fixed by #16
Closed

[Feature Request] Restrict privileged command to bot admins #14

Generator opened this issue Feb 20, 2024 · 3 comments · Fixed by #16
Assignees
Labels
done Job is done :) enhancement New feature or request

Comments

@Generator
Copy link

Description

In a group or private, any user can use privileged commands (/reset, /provider)

Restrict privileged command to bot admin(s) only.

Example:
ADMINS="@User1,@User2"

@s-nagaev
Copy link
Owner

Hello! Thank you for the feature request! The proposed functionality is interesting and useful. I'm confident that I will implement it in the near future, but right now it doesn't make much sense. The fact is that even when in a group chat, Hiroshi operates an individual context when communicating with each participant of the group. That is, if a person performs a /reset, they erase their own communication history. There is no shared communication history kept. Not yet.

I plan to implement a special behavior for the bot in group chats in the near future, where the communication history will be shared across the entire chat. And yes, in such a case, it would be necessary to provide the feature you requested.

@s-nagaev s-nagaev added postponed Issue/request makes sense, but will be implemented later enhancement New feature or request labels Feb 23, 2024
@Generator
Copy link
Author

Generator commented Feb 23, 2024

What about /provider?
Some providers could break the bot, due to unresponsive.

When i change the ASSISTANT_PROMPT (and restart container) i always do reset, so it uses the new prompt, otherwise continues to use the previous.

Or maybe takes some time.
I notice that conversations had separate chats for private, didn't know about groups.

@s-nagaev s-nagaev added in progress Task at work and removed postponed Issue/request makes sense, but will be implemented later labels Feb 24, 2024
@s-nagaev
Copy link
Owner

@Generator same :) Buuuut, you know what... I gonna add the "group" behaviour by the Monday :) And feature you've requested is gonna be implemented as well.

@s-nagaev s-nagaev self-assigned this Feb 24, 2024
@s-nagaev s-nagaev linked a pull request Feb 25, 2024 that will close this issue
@s-nagaev s-nagaev added done Job is done :) and removed in progress Task at work labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Job is done :) enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants