Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexColorPicker Demo Slider issue #64

Closed
iqfareez opened this issue Jan 13, 2023 · 4 comments
Closed

FlexColorPicker Demo Slider issue #64

iqfareez opened this issue Jan 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@iqfareez
Copy link

This is just minor visual issue on the demo apo (I think)

2023-01-13.09-20-32.mp4
@rydmike rydmike self-assigned this Jan 13, 2023
@rydmike rydmike added the bug Something isn't working label Jan 13, 2023
@rydmike rydmike added this to To do in TODOs via automation Jan 13, 2023
@rydmike rydmike added this to the v6.0.2 milestone Jan 13, 2023
@rydmike
Copy link
Owner

rydmike commented Jan 13, 2023

Thanks @iqfareez, confirmed it is bug in the web demo app and only in it.

The Slider and it value should update. The Picker component is updating correctly but slider does not move. That the slider below it moves is correct, its value actually remains same, but it max border radius slider range increases as the picker item sizes increase, so it moves as max moves further away.

But yeah the picker item size Slider should update too. Pushing a fix and building new version of web app now...

@rydmike rydmike moved this from To do to Released on pub.dev in TODOs Jan 13, 2023
@rydmike
Copy link
Owner

rydmike commented Jan 13, 2023

Package that includes fixed web demo published.
The actual Web demo update is still building via GitHub action and will be updated automatically on its GitHub pages hosting as well. You should see it live in maybe 15 min.

@rydmike
Copy link
Owner

rydmike commented Jan 13, 2023

The fixed web demo is live. Thanks for the bug report! 💙

@rydmike rydmike modified the milestones: v6.0.2, 3.0.2 Jan 13, 2023
@iqfareez
Copy link
Author

Great. Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
TODOs
Released on pub.dev
Development

No branches or pull requests

2 participants