Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#312 PR broke my setup #338

Closed
Vorsku opened this issue Dec 26, 2020 · 4 comments
Closed

#312 PR broke my setup #338

Vorsku opened this issue Dec 26, 2020 · 4 comments

Comments

@Vorsku
Copy link

Vorsku commented Dec 26, 2020

Hi,

pull request #312 seems to have broken my setup.

I previously had base_url set to https://docs.domain.com which worked prior to the release of 0.16.5

Now when I try to use 0.16.5 I get 'Cannot GET /' in the browser. Changing base_url to blank fixes the issue, however it means I can no longer use %base_url% in documentation to reference the base URL

Thanks

@ryanlelek
Copy link
Owner

Thank you for letting us know and so quickly.
I'll look into this in a bit.

To clarify, you had config.base_url set to https://docs.domain.com and in the documentation files (.md extension), they are not resolving %base_url%. You must set config.base_url to '' to get it somewhat working again.

@Vorsku
Copy link
Author

Vorsku commented Dec 26, 2020

Hi,

Thanks for the quick reply!

To clarify, I am running it in the LSIO docker container - when the container starts and I browse to https://docs.domain.com it doesn't load the normal Raneto index page, it just brings up the error "Cannot Get /"

IMG_20201226_134717.jpg

To fix this, in the config.default.js file I had to do:
Screenshot_2020-12-26-15-56-01-721_com.sonelli.juicessh~2.jpg

I believe the fact that I can no longer use %base_url% in files is just because it's now blank.

Thanks,
Josh

@ryanlelek
Copy link
Owner

Ok, here's what I found:

    1. I have confirmed the bug. "" works and "[any base uri]" gives the "Cannot GET /" error
    1. Putting nowrap: true, under the base_url parameter solves the issue
    1. Warning: this will load ALL assets through that Base URL, including site assets. This goes beyond Markdown files %base_url%

Please add the nowrap: true, to your config and let me know if that resolves. If it does, I'll add the nowrap parameter to the example and republish.

@Vorsku
Copy link
Author

Vorsku commented Dec 26, 2020

Yep this now works! Thanks @ryanlelek

IMG_20201226_194951.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants