Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password validation bug #549

Closed
mineminemine opened this issue Nov 18, 2021 · 3 comments
Closed

Password validation bug #549

mineminemine opened this issue Nov 18, 2021 · 3 comments

Comments

@mineminemine
Copy link

Describe the bug

As of version 2.1.6 (or I believe since version 2.1.4), the password no longer properly validates special characters. It no longer looks out for special characters in the password string.
This bug was probably introduced in the fix for #486.

So for example, if I have the validation for specialCharacter set to true:

  • "Test1234" would return true (this should return false since there is no special characters)
  • "Test1234@" would also return true (correct behaviour since all validations are true)
  • "Test" would return false
  • "1234" would also return false
  • "!!!!!!" would also return false

Expected Behavior

Account for special character in the password string.

  • "Test1234" should return false since there is no special character here

To Reproduce

You may refer to the URL below for the example.

Url (stackblitz or plunker or other)

https://stackblitz.com/edit/angular-khenkh-hncomt?file=package.json

Package Version

"@rxweb/reactive-form-validators": "~2.1.6"

@pranavirabatti
Copy link
Contributor

#568

@kunalfleethawks
Copy link

Any update on this?

@ajayojha
Copy link
Member

ajayojha commented May 9, 2022

the issue has been fixed, please install 2.1.7 version.

@ajayojha ajayojha closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants