Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'@rxweb/reactive-form-validators' package code optimization #193

Open
ajayojha opened this issue Aug 21, 2019 · 0 comments
Open

'@rxweb/reactive-form-validators' package code optimization #193

ajayojha opened this issue Aug 21, 2019 · 0 comments

Comments

@ajayojha
Copy link
Member

Description

If someone is using the only validator or decorator in his/her application then internally the whole code will be included in the final dist package. Which is a bit obnoxious (as per me :)). Because unnecessary code will be included in the final package.

Describe the solution you'd like

Create separate two modules one is for validator and the second one is for the decorator if someone will only use validator then the validator related code will be included otherwise the whole code because internally decorator is using the validator code.

@ajayojha ajayojha self-assigned this Aug 21, 2019
@ajayojha ajayojha added this to To do in who is doing what? via automation Aug 21, 2019
@ajayojha ajayojha removed this from the 1.9.3@reactive-form-validators milestone Sep 6, 2019
@ajayojha ajayojha added the rxweb label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant