feat: shell completions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aawsome
reviewed
Sep 12, 2022
|
@istudyatuni Are you still working on this PR? I would love to add this feature to the next release which I'm planning to release within the next days. |
|
Yeah, sorry, studying now a lot. Will return to this in 1-3 days (I hope). Also question - maybe do not hide completions behind feature, and provide this by default? Like in poetry |
|
No worries and no need to hurry. I'm just trying to get things closed which can be closed 😉
Yes, this is for sure an option. |
This reverts commit de17658.
|
Done |
aawsome
reviewed
Sep 29, 2022
|
About squashing - maybe make a squash merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #193
Depends on#194Not sure where is better place to write docs about installing completions. Also that this way for generating is good