Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Use RMSNorm for normalization #80

Closed
Tracked by #81
philpax opened this issue Mar 26, 2023 · 0 comments
Closed
Tracked by #81

Use RMSNorm for normalization #80

philpax opened this issue Mar 26, 2023 · 0 comments
Assignees
Labels
issue:enhancement New feature or request

Comments

@philpax
Copy link
Collaborator

philpax commented Mar 26, 2023

Upstream has switched to using RMSNorm for normalization, which is more accurate to the original implementation: ggerganov/llama.cpp#173

We didn't do this at first because there seemed to be some issues, but those seem to have been resolved.

@philpax philpax added the issue:enhancement New feature or request label Mar 26, 2023
This was referenced Mar 26, 2023
@philpax philpax self-assigned this Mar 27, 2023
@philpax philpax closed this as completed in cdb630d Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant