-
Notifications
You must be signed in to change notification settings - Fork 351
Clarify MSRV policy #431
Comments
Hi there! The MSRV is 1.65.0; this is specified in the README and the CI, which builds with 1.65.0. However, I'll admit that this is not the most obvious and it should be present in the workspace's
That's just for Where else would you like the MSRV to be specified? |
Oh I assume this line My opinion is that following https://rust-lang.github.io/rfcs/2495-min-rust-version.html would be the best. Also, I think a MSRV policy would help both users and contributors understand when and how MSRV changes will be handled. README.md is fine, or a separate CONTRIBUTING.md could be used as well. |
In a recent PR #429 @philpax mentions a MSRV constraints.
I cannot find any documentation regarding the current MSRV and related policy.
A search on the code reveals these details :
llm/binaries/llm-cli/Cargo.toml
Line 34 in 84800b0
(This is from a previous version of this repo and I am unable to find the corresponding current code)
llm/llama-rs/Cargo.toml
Line 5 in 75e9bbb
#375
in the current
Cargo.toml
:https://github.com/rustformers/llm/blob/main/Cargo.toml#L42C18rust-toolchain-version = "1.67.1"
is this the same as setting MSRV to 1.67?
So I assume current msrv is
1.65
or1.67
? but I hope this is clarified in the relevant README.md, Cargo.toml etcThe text was updated successfully, but these errors were encountered: