Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename config.toml to bootstrap.toml #126875

Open
jyn514 opened this issue Jun 23, 2024 · 5 comments
Open

rename config.toml to bootstrap.toml #126875

jyn514 opened this issue Jun 23, 2024 · 5 comments
Assignees
@LuuuXXX
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 23, 2024 •
edited by rustbot
Loading

cargo and bootstrap use the same name for their configuration file. this is confusing. we might want to rename this file so it's easier to understand what's going on.

this will also make it easier to write .gitignore style includes and excludes without mixing up the two types of configs.

@rustbot label A-contributor-roadblock T-bootstrap
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 23, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 24, 2024
@onur-ozkan
Copy link
Member

If we do that, if bootstrap.toml don't exist we should fallback to config.toml so we don't break the downstreams.

@Nilstrieb Nilstrieb mentioned this issue Jul 7, 2024
Merged
@Nilstrieb
Copy link
Member

our docs have also been confused about this before: #127236

@LuuuXXX
Copy link
Contributor

LuuuXXX commented Jul 8, 2024

Any progress on this? I'm happy to help.

@onur-ozkan
Copy link
Member

Any progress on this? I'm happy to help.

Feel free to claim the task.

@LuuuXXX
Copy link
Contributor

LuuuXXX commented Jul 8, 2024

@rustbot claim

@LuuuXXX LuuuXXX mentioned this issue Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuuuXXX LuuuXXX

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jyn514 @onur-ozkan @LuuuXXX @rustbot @Nilstrieb