-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Occasional memory leak in mpsc channels #121582
Labels
I-memleak
Issue: Runtime memory leak without `mem::forget`.
S-has-mcve
Status: A Minimal Complete and Verifiable Example has been found for this issue
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Feb 25, 2024
I think this is not recent, it's just hard to trigger. I'll try reproducing on some older versions of rustc+Miri:
We can't go back much further since it seems we're not keeping the artifacts long enough for that? So probably this existed ever since #93563 landed. |
Reproduced this with crossbeam-channel 0.5.11 and miri 381d699`. |
jieyouxu
added
I-memleak
Issue: Runtime memory leak without `mem::forget`.
S-has-mcve
Status: A Minimal Complete and Verifiable Example has been found for this issue
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Feb 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-memleak
Issue: Runtime memory leak without `mem::forget`.
S-has-mcve
Status: A Minimal Complete and Verifiable Example has been found for this issue
Running this test:
with many different seeds in Miri eventually shows:
This indicates that the allocation made here does not get freed properly:
rust/library/std/src/sync/mpmc/list.rs
Line 209 in f0d487d
Specifically when running this with Miri 3fe10973bb6e9a01b280686534d0242da07f3ede, seed 139 causes the issue.
I don't think there is any way for this to be a false positive.
Cc @ibraheemdev @taiki-e @Amanieu
The text was updated successfully, but these errors were encountered: