Skip to content

Commit

Permalink
Rollup merge of #125566 - camelid:notify-accepted, r=GuillaumeGomez
Browse files Browse the repository at this point in the history
Notify T-rustdoc for beta-accepted and stable-accepted too

Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.

r? ````@GuillaumeGomez````
  • Loading branch information
workingjubilee authored May 26, 2024
2 parents 25b079a + 91b3ef5 commit 45507e4
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions triagebot.toml
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,19 @@ message_on_remove = "PR #{number}'s beta-nomination has been removed."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the beta-accepted+T-rustdoc action fully occupies the beta-accepted slot
# preventing others from adding more beta-accepted actions.
[notify-zulip."beta-accepted"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
# Put it in the same thread as beta-nominated.
topic = "beta-nominated: #{number}"
message_on_add = "PR #{number} has been **accepted** for beta backport."
message_on_remove = "PR #{number}'s beta-acceptance has been **removed**."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the stable-nominated+T-rustdoc action fully occupies the stable-nominated slot
# preventing others from adding more stable-nominated actions.
Expand All @@ -492,6 +505,19 @@ message_on_remove = "PR #{number}'s stable-nomination has been removed."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
# At the moment, the stable-accepted+T-rustdoc action fully occupies the stable-accepted slot
# preventing others from adding more stable-accepted actions.
[notify-zulip."stable-accepted"]
required_labels = ["T-rustdoc"]
zulip_stream = 266220 # #t-rustdoc
# Put it in the same thread as stable-nominated.
topic = "stable-nominated: #{number}"
message_on_add = "PR #{number} has been **accepted** for stable backport."
message_on_remove = "PR #{number}'s stable-acceptance has been **removed**."
message_on_close = "PR #{number} has been closed. Thanks for participating!"
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."

[notify-zulip."I-types-nominated"]
zulip_stream = 326866 # #T-types/nominated
topic = "#{number}: {title}"
Expand Down

0 comments on commit 45507e4

Please sign in to comment.