Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename lint THREAD_LOCAL_INITIALIZER_CAN_BE_MADE_CONST #12934

Open
alex-semenyuk opened this issue Jun 15, 2024 · 4 comments · May be fixed by #12974
Open

Rename lint THREAD_LOCAL_INITIALIZER_CAN_BE_MADE_CONST #12934

alex-semenyuk opened this issue Jun 15, 2024 · 4 comments · May be fixed by #12974

Comments

@alex-semenyuk
Copy link
Contributor

alex-semenyuk commented Jun 15, 2024 •
edited
Loading

Description

Existing lint THREAD_LOCAL_INITIALIZER_CAN_BE_MADE_CONST sounds against convention for other lints which describe the issue/wrong code but not suggestion. Also the name is quite long.

Version

No response

Additional Labels

No response
@alex-semenyuk alex-semenyuk changed the title Rename lint THREAD_LOCAL_INITIALIZER_CAN_BE_MADE_CONST Rename lint THREAD_LOCAL_INITIALIZER_CAN_BE_MADE_CONST Jun 15, 2024
@m-rph
Copy link
Contributor

m-rph commented Jun 16, 2024

Any suggestions? Iirc we iterated a bit until we found a descriptive enough name.

@y21
Copy link
Member

y21 commented Jun 16, 2024

missing_const_for_tls or missing_const_for_threadlocal would be in line with missing_const_for_fn (would help w/ the length at least)

@m-rph
Copy link
Contributor

m-rph commented Jun 16, 2024

missing_const_for_tl_init perhaps?

@alex-semenyuk
Copy link
Contributor Author

+1 missing_const_for_tl_init

@alex-semenyuk alex-semenyuk linked a pull request Jun 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alex-semenyuk @y21 @m-rph