Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O_ flag support #3744

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add O_ flag support #3744

merged 2 commits into from
Jul 22, 2024

Conversation

newpavlov
Copy link
Contributor

No description provided.

src/shims/unix/fs.rs Outdated Show resolved Hide resolved
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please also add a test (pass-dep/libc/libc-fs.rs seems like the right place).

src/shims/unix/fs.rs Outdated Show resolved Hide resolved
src/shims/unix/fs.rs Show resolved Hide resolved
src/shims/unix/fs.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

Please also add a test (pass-dep/libc/libc-fs.rs seems like the right place).

Specifically, that file can have a test where the file is not a symlink and we just check that the flag is supported.

The test where the file is a symlink should go into tests/pass-dep/libc/libc-fs-readlink.rs (which we should probably rename to libc-fs-symlinks); that file is skipped on Windows hosts since on Windows we can't create symlinks when we're not admins...

@RalfJung RalfJung added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Jul 22, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/miri.git master
$ git push --force-with-lease

The following commits are merge commits:

@newpavlov newpavlov requested a review from RalfJung July 22, 2024 14:32
@RalfJung
Copy link
Member

Looks good, thanks. :)
@bors r+

@bors
Copy link
Collaborator

bors commented Jul 22, 2024

📌 Commit b7bbf7f has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 22, 2024

⌛ Testing commit b7bbf7f with merge b8753be...

@bors
Copy link
Collaborator

bors commented Jul 22, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b8753be to master...

@bors bors merged commit b8753be into rust-lang:master Jul 22, 2024
8 checks passed
@newpavlov newpavlov deleted the branch July 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: Waiting for the PR author to address review comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants